search

brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.07k stars 163 forks source link

Added dpp::cluster::guild_member_timeout_remove and its sync/coro versions #1067

Closed AA1999 closed 9 months ago

AA1999 commented 9 months ago

I've added dpp::cluster::guild_member_timeout_remove, dpp::cluster::guild_member_timeout_remove_sync and dpp::cluster::co_guild_member_timeout_remove and added documentation for them.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

netlify[bot] commented 9 months ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 24385b5ac7779d5195a946db1071d440ab50746a
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65b0f566831ddb000739399a
Deploy Preview https://deploy-preview-1067--dpp-dev.netlify.app/classdpp_1_1cluster
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

braindigitalis commented 9 months ago

how did you add the coro and sync version? did you do it by rerunning the builder scripts for it?

AA1999 commented 9 months ago

I just called guild_timeout_remove_sync and co_guild_timeout with communication_disabled_until set to 0 Returned the result in the coro version

braindigitalis commented 9 months ago

the coro and sync are auto generated, you shouldn't manually put stuff in those files. when someone runs cmake it will remove your changes.

you need to make sure the auto generation picks up your changes. because they don't match the correct pattern this won't work as is. you should make them not just call another function and instead call the REST stuff

AA1999 commented 9 months ago

Where's the script for these? Is it in one of the CMakeLists? Also why not call the function with a 0 parameter if I'm doing the exact same thing with one different variable?

Jaskowicz1 commented 9 months ago

Where's the script for these? Is it in one of the CMakeLists? Also why not call the function with a 0 parameter if I'm doing the exact same thing with one different variable?

No, it happens when you call cmake -B build or cmake ..

AA1999 commented 9 months ago

I did use cmake -B and cmake --build before pushing Dunno if that'd help or not

braindigitalis commented 9 months ago

it's a set of php scripts in the buildtools folder that do this, there's a base class, and a derived version of it for coro and sync.

you should not need to modify these scripts.