search

brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.05k stars 159 forks source link

Merge change_voice_channel into connect_voice #1085

Closed SelfishPig closed 6 months ago

SelfishPig commented 6 months ago

There's actually no reason for change_voice_channel to be it's own function. When would a user ever call connect_voice and not expect it to connect to the channel they specified if it's not already connected? This change doesn't break any existing functionality.

netlify[bot] commented 6 months ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 2a1b732cd8e05bef1e976dc2e6a9fb74e5c5e9cb
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65d256de8abe6b0008f563e9
Deploy Preview https://deploy-preview-1085--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1 commented 6 months ago

So, will change_voice_channel exist alongside this? Your current changes show you're keeping change_voice_channel and changing connect_voice.

SelfishPig commented 6 months ago

So, will change_voice_channel exist alongside this? Your current changes show you're keeping change_voice_channel and changing connect_voice.

No, it will not. Sorry, trying to figure out to make github happy.

SelfishPig commented 6 months ago

So, will change_voice_channel exist alongside this? Your current changes show you're keeping change_voice_channel and changing connect_voice.

There we go. Cheers.