fix: ts_not_null now works for all timezones

Jaskowicz1 commented 6 months ago

This PR fixes the ts_not_null unittest breaking on a non-UTC machine. It also fixes set_ts_not_null.

For more understanding, mktime returns a local time, not a UTC time. It's also not based off your BIOS time, as previously assumed in #1063, but rather the user-level time.

Fixes #1063

Code change checklist

[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] My code follows the coding style guide.
[x] I tested that my change works before raising the PR.
[x] I have ensured that I did not break any existing API calls.
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

netlify[bot] commented 6 months ago

Deploy Preview for dpp-dev ready!

Name	Link
Latest commit	ef5816c4daaf0d4ad07039773f98aaf23810a70a
Latest deploy log	https://app.netlify.com/sites/dpp-dev/deploys/65d3545aeef2b200081b68e9
Deploy Preview	https://deploy-preview-1089--dpp-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for dpp-dev ready!

Name	Link
Latest commit	d41009cbcbc52531430f9966f193ae6ca3e60cb7
Latest deploy log	https://app.netlify.com/sites/dpp-dev/deploys/65d357450ff85a00089566e3
Deploy Preview	https://deploy-preview-1089--dpp-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brainboxdotcc / DPP