brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.04k stars 158 forks source link

fix: correct wrong linking order to fix static build #1102

Closed Syping closed 5 months ago

Syping commented 5 months ago

Build DPP statically causing linker errors with OpenSSL with undefined references

/usr/bin/ld: s3_lib.c:(.text+0x348): undefined reference to `OPENSSL_sk_pop_free'
/usr/bin/ld: s3_lib.c:(.text+0x35c): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x377): undefined reference to `CRYPTO_clear_free'
/usr/bin/ld: s3_lib.c:(.text+0x38b): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x39f): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x3ab): undefined reference to `EVP_PKEY_free'
/usr/bin/ld: s3_lib.c:(.text+0x3b7): undefined reference to `EVP_PKEY_free'
/usr/bin/ld: s3_lib.c:(.text+0x3d3): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x3e7): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x440): undefined reference to `CRYPTO_free'

So i corrected the linking order to fix that problem.

Code change checklist

netlify[bot] commented 5 months ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit c3d62a65920b055c4ea5da75c25fd89b0a7dfcbd
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65e33945459a380008ff4fc4
Deploy Preview https://deploy-preview-1102--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

braindigitalis commented 5 months ago

thanks, merged!