fix: out-of-bounds read of MIME types

VoltrexKeyva commented 5 months ago

Since i is the index, it should be less than the size of the vector but the mimetypes.size() < i condition does not check for i being the same as the size of the vector, which causes an out-of-bounds read in the right operand of the logical OR (||) operator which is mimetypes[i].empty().

Code change checklist

[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] My code follows the coding style guide.
[x] I tested that my change works before raising the PR.
[x] I have ensured that I did not break any existing API calls.
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

netlify[bot] commented 5 months ago

Deploy Preview for dpp-dev ready!

Name	Link
Latest commit	646c11f5b88c540f935a277434430a542365ccfb
Latest deploy log	https://app.netlify.com/sites/dpp-dev/deploys/65e5ca0a27c27d0008cdcc11
Deploy Preview	https://deploy-preview-1104--dpp-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

braindigitalis commented 5 months ago

~~no, i dont think this fix is right!~~

~~vectors are 0-based so its 0 thru n - 1, if you try to access n, this indeed would then be out of bounds...~~

braindigitalis commented 5 months ago

thanks, i'll merge it as is :)

brainboxdotcc / DPP