fix: error in logging with malformed json that doesnt fit the structure for an error

brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!

https://dpp.dev/

Apache License 2.0

1.04k stars 158 forks source link

Closed braindigitalis closed 3 months ago

braindigitalis commented 4 months ago

adds a try/catch around log_error internals to catch malformed or incorrect error output such as null error jsons

[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] My code follows the coding style guide.
[x] I tested that my change works before raising the PR.
[x] I have ensured that I did not break any existing API calls.
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

netlify[bot] commented 4 months ago

Name	Link
Latest commit	2c2ae178bb72c83fa15ac73df08c22e98afab46f
Latest deploy log	https://app.netlify.com/sites/dpp-dev/deploys/66327a154c0b390008550eba
Deploy Preview	https://deploy-preview-1126--dpp-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

braindigitalis commented 4 months ago

we can discard the changes from confirmation.cpp keeping the dev branch version and just keep the catch()

Mishura4 commented 4 months ago

Sounds good