brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.01k stars 155 forks source link

feat: added warnings for certain events that require an intent #1169

Closed Jaskowicz1 closed 2 weeks ago

Jaskowicz1 commented 1 month ago

This PR adds warnings for some events (guild member events and presence update) if the user does not have the specific intent required.

As these events do not fire from Discord if the intent wasn't specified, I could not use the set_warning_callback feature.

This is to try and inform users about what went wrong and how they can fix it, to try be more user friendly as D++ is currently silent about it (see link a and link b).

Code change checklist

netlify[bot] commented 1 month ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 16917aa09c84fb0d6e505f7bb8bf956fe6bfa981
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/666ab1bfecac7b000895c452
Deploy Preview https://deploy-preview-1169--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1 commented 4 weeks ago

what about if the user hooks the event after starting the cluster?

Couldn't come up with a solution to that, that didn't involve constantly checking every second if the events have been bound to, when I was writing this (and I still don't have a solution).

also, while looking at this do we make the one for messages less spammy too? basically make them all emit once?

Either that or add something like bot.suppress_warnings(true); to prevent warning logs for this (for people who do know what they're doing)? I think being spammy drills in the idea that they're doing something wrong to people who might not understand.