search

brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.01k stars 155 forks source link

docs: Altered minimum gcc version for Coro, fixed docs issues #1173

Closed Jaskowicz1 closed 2 weeks ago

Jaskowicz1 commented 4 weeks ago

This PR raises the minimum gcc/g++ version for Coro from 11 to 13.

This PR also corrects set_emoji (too much text for a @brief, moved most of it to @warning and @note) and set_disabled (previously stated that both true and false would disable a component).

Documentation change checklist

netlify[bot] commented 4 weeks ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 15d5993d6f8eba915931edd42f0993d5ed0c6b6d
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/667734280e72b90008e0d24e
Deploy Preview https://deploy-preview-1173--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

braindigitalis commented 4 weeks ago

are you sure 13 is the minimum? ive been using it on v12 in seven spells and beholder just fine, and on my local machine...

Jaskowicz1 commented 4 weeks ago

are you sure 13 is the minimum? ive been using it on v12 in seven spells and beholder just fine, and on my local machine...

Not entirely sure to be honest with you. I was under the impression it was gcc13 as minimum.

If you're running coro on 12 then I'll change it to gcc12!

Mishura4 commented 4 weeks ago

It's for ARM that you need 13

For x86 11 and 12 work but have bugs with lambdas (we already warn about this one in docs)

Jaskowicz1 commented 4 weeks ago

For x86 11 and 12 work but have bugs with lambdas (we already warn about this one in docs)

https://discord.com/channels/825407338755653642/825411707521728512/1252545524717064235 https://discord.com/channels/825407338755653642/825411707521728512/1225743126602317834 is it?

Seems like 11 and 12 have issues on these machines (both cases are debian 12 though, so maybe it's a debian thing).

Mishura4 commented 4 weeks ago

It's for ARM that you need 13

Jaskowicz1 commented 4 weeks ago

So, to now update this, it seems it's only gcc12.3 or higher and then a specific version of gcc11 that works.

From talks, it's best to just tell people to use gcc13 or higher. This answers your question about it working on your end @braindigitalis