fix: fix leak of in_thread, fix read-after-free, fix race condition UB after cluster shutdown

brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!

https://dpp.dev/

Apache License 2.0

1.01k stars 155 forks source link

fix: fix leak of in_thread, fix read-after-free, fix race condition UB after cluster shutdown #1187

Closed Mishura4 closed 1 week ago

Mishura4 commented 1 week ago

Title

Code change checklist

[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] My code follows the coding style guide.
[x] I tested that my change works before raising the PR.
[x] I have ensured that I did not break any existing API calls.
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

github-actions[bot] commented 1 week ago

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

netlify[bot] commented 1 week ago

Deploy Preview for dpp-dev ready!

Name	Link
Latest commit	40cbdb8b504342c06a4e98965ce59815fb871506
Latest deploy log	https://app.netlify.com/sites/dpp-dev/deploys/6688dc06b6ec19000846f14f
Deploy Preview	https://deploy-preview-1187--dpp-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1 commented 1 week ago

Looks all good to me!

brainboxdotcc / DPP

fix: fix leak of in_thread, fix read-after-free, fix race condition UB after cluster shutdown #1187

Code change checklist

✅ Deploy Preview for dpp-dev ready!

Deploy Preview for dpp-dev ready!