Closed Mishura4 closed 6 days ago
Name | Link |
---|---|
Latest commit | 6eef94ad745260c13a7dd943c59212a8c1e8d839 |
Latest deploy log | https://app.netlify.com/sites/dpp-dev/deploys/668fdaea61faa60008cce518 |
Deploy Preview | https://deploy-preview-1188--dpp-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This is huge, god damn.
I'll pull this branch locally and test this with my bot, will give you a shout on Discord if I have any issues!
lgtm, will test it out when its in dev as the coro features in my bot arent complete so i can't test this thoroughly.
Closing to reopen from https://github.com/brainboxdotcc/DPP/tree/coro
This is a massive PR that fundamentally changes the coro implementation, everything is a derivative of dpp::awaitable and dpp::promise now. This helps with de-duplicating a lot of coro-related code, making it easier to maintain, and offers a way to add things to all of the coroutine types at once, for example the
sync_wait
method available on all awaitable types, which can help for example with starting a coroutine from a non-coroutine.Still missing some documentation & polishing
Code change checklist