brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.07k stars 163 forks source link

feat: banners can now be uploaded to bots #1197

Closed Jaskowicz1 closed 3 months ago

Jaskowicz1 commented 3 months ago

This PR adds the ability to add banners to bots. I have also removed the limit imposed on avatars and banners as it seems the 256kb limit isn't true.

Code change checklist

netlify[bot] commented 3 months ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit fa749ce1520c0ab21843a439148f27d3eb0b3b26
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6693bac59398a30008169014
Deploy Preview https://deploy-preview-1197--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1 commented 3 months ago

forgor to cmake -B build lol

Jaskowicz1 commented 3 months ago

Converted to draft, need to experiment with file limits as it seems avatars and banners do not have a 256kb constraint.

Jaskowicz1 commented 3 months ago

No longer draft!

Jaskowicz1 commented 3 months ago

I found that banners and avatars have no limit for bots? It could possibly be 25MB but Discord doesn't document this and it seems the request times out at anything over 9mb (at least it did for me). I assume it's a combination of can you upload in time and can Discord process it in time to respond, otherwise it throws a malformed HTTP request.

So, this PR now removes the limit for avatars and banners.