Closed ruslan-ilesik closed 1 month ago
Name | Link |
---|---|
Latest commit | bc01f2f981264446d095c1daad1451947bdc13a9 |
Latest deploy log | https://app.netlify.com/sites/dpp-dev/deploys/66af6403ef8ab6000889141f |
Deploy Preview | https://deploy-preview-1203--dpp-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
tested this on Windows and got
snowflake: std::format support PASS
at the end
So with last commit i have introduced usage of Cmake feature called configure_file which allows us autogenerate headers with some definitions when build dpp, this way we can remove need to define DPP_HAS_FORMAT as it will be defined in it when compiling it.
In theory same way we can eliminate need to specify -DDPP_CORO when compiling bot with dpp with coro enabled in lib.
If lib is build with c++20 then ye, bots will be required to use c++20, I can easily fix it by wrapping cmake define into check of c++ version.
I have tested changes locally on my wsl2 (ubuntu) and tests passed, also compiling bot with -DPP_FORMATTERS and without had required behavior
This pr adds std::format support for dpp::snowflake, if we do not have c++20 or have no include for it will be automatically disabled for compilation.
Test case was implemented to check formatting.
Code change checklist