brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.05k stars 159 forks source link

docs: Remove coroutine/DPP_CORO experimental warnings #1221

Open DJOetzi opened 1 month ago

DJOetzi commented 1 month ago

Removed notices of coroutines being an experimental feature.

Documentation change checklist

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

netlify[bot] commented 1 month ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 7d32b2636042f89fd6fbed9d2e1d2b34846c9ac9
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66d87de50fbc5000084914a9
Deploy Preview https://deploy-preview-1221--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1 commented 2 weeks ago

Any update on this?

DJOetzi commented 1 week ago

You're missing

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/job.h#L48

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/async.h#L103

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/library/CMakeLists.txt#L292

(just remove the word "experimental" here, keep the message()). https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/task.h#L87

https://github.com/brainboxdotcc/DPP/blob/ced36fd7652ed24ec3784cbc150722a1e5f6456a/include/dpp/coro/coroutine.h#L67

should I just remove these comments altogether?