brainboxdotcc / DPP

C++ Discord API Bot Library - D++ is Lightweight and scalable for small and huge bots!
https://dpp.dev/
Apache License 2.0
1.05k stars 159 forks source link

fix: Improve compatiblity with socket #1229

Closed TracerDS closed 1 week ago

TracerDS commented 2 weeks ago

This PR improves compatiblity with other projects that DPP is included into.

#include <dpp/win32_safe_warnings.h> is to prevent dll-interface warnings while compiling the main application.

#ifndef SOCKET is used to prevent possible incompatiblities with projects that already handle that case (such as network libraries). This way the socket will still be defined but only if it wasnt earlier.

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

netlify[bot] commented 2 weeks ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit 0fe5f2b90a94f79999bd03808cbf7ad9ef4a9ba7
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66cb12d506673600080859e1
Deploy Preview https://deploy-preview-1229--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for dpp-dev ready!

Name Link
Latest commit ec9f59f3208bdbd8071e7bd520189a66336c2ebd
Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66d44ff7596b360008be4af6
Deploy Preview https://deploy-preview-1229--dpp-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1 commented 2 weeks ago

Renamed PR to follow naming scheme