braincrafted / bootstrap-bundle

BraincraftedBootstrapBundle integrates Bootstrap into Symfony2 by providing templates, Twig extensions, services and commands.
http://bootstrap.braincrafted.com
MIT License
399 stars 182 forks source link

Upgrade to symfony 2.6 compatible form extensions #374

Closed kralos closed 9 years ago

kralos commented 9 years ago

As of symfony 2.6

public function configureOptions(OptionsResolver $resolver)
{
    $resolver->setDefined(array(/** 'option1', 'option2' */));
}

should be used instead of:

public function setDefaultOptions(OptionsResolverInterface $resolver)
{
    $resolver->setOptional(array(/** 'option1', 'option2' */));
}

As of 2.7 the former method is also deprecated

althaus commented 9 years ago

:+1:

kralos commented 9 years ago

Fixed https://github.com/braincrafted/bootstrap-bundle/pull/375

althaus commented 9 years ago

You missed to update the form types accordingly. I'll prepare a separate PR to fix this issue.

althaus commented 9 years ago

Sorry for the two commits here. Missed to tell the repo to not f*\ up the lineendings at first. :hammer: