search

braincrafted / bootstrap-bundle

BraincraftedBootstrapBundle integrates Bootstrap into Symfony2 by providing templates, Twig extensions, services and commands.
http://bootstrap.braincrafted.com
MIT License
399 stars 182 forks source link

font-awesome <span> -> <li> #389

Open Tetdoss opened 9 years ago

Tetdoss commented 9 years ago

Hello, your bundle works fine with font-awesome but font-awesome use < li > instead of < span > to display icon. It doesn't change anything but there are issues with others plugins.

For example, i'm using AdminLTE which uses font-awesome but when i want to use your {{icon...}} twig function, it is replaced with < span > and the css of AdminLTE doesn't handle < span > to display icon.

So can you normalize your bundle and use < li > instead of < span > for the font-awesome icons ?

Thank you ;)

vrnagy commented 9 years ago

You can change the icon_tag config parameter like:

braincrafted_bootstrap:
    icon_tag: i
florianeckerstorfer commented 9 years ago

We should totally change the default value to i in a feature release.

Tetdoss commented 9 years ago

Thanks for your answers, in fact I have this issue because i'm using bootstrap (useful for the carousel for example) AND font-awesome icon. But I'll try to use only font-awesome ;)