search

braincrafted / bootstrap-bundle

BraincraftedBootstrapBundle integrates Bootstrap into Symfony2 by providing templates, Twig extensions, services and commands.
http://bootstrap.braincrafted.com
MIT License
399 stars 184 forks source link

Bootstrap 4 support? #438

Open melroy89 opened 8 years ago

melroy89 commented 8 years ago

I can use sass with the bootstrap-sass bundle, but that is Bootstrap version 3...

I would like to use Bootstrap 4.0 (alpha) using bootstrap-bundle. I already know how to configure sass in bootstrap-bundle.

But currently when I configure sass it tries to search in the boostrap-sass bundle (not wanted behaviour!). However the new Bootstrap 4.0 version has sass out of the box. This version is just located at: vendor/twbs/bootstrap.

Current composer.json setup:

"braincrafted/bootstrap-bundle": "dev-master",
"twbs/bootstrap": "4.0.*",
"symfony/assetic-bundle": "^2.8",

Thanks already for supporting Bootstrap 4 in the (hopefully) near future!

Kind regards, Melroy van den Berg

lashus commented 7 years ago

As i've looked upon it there's much more. My fix is irrelevant and should be cleaned out of discussion. Js file list also differs, there should be some kind of "switch" between version. Also some classes have changed so the new branch is required for twbs v4.

melroy89 commented 7 years ago

Thanks for working on it.