braincrafted / bootstrap-bundle

BraincraftedBootstrapBundle integrates Bootstrap into Symfony2 by providing templates, Twig extensions, services and commands.
http://bootstrap.braincrafted.com
MIT License
399 stars 184 forks source link

Can you tag a new release with symfony 4 support? #469

Open andrew-demb opened 4 years ago

andrew-demb commented 4 years ago

Hello.

This commit (https://github.com/braincrafted/bootstrap-bundle/commit/2a3597808971b355bf2f7b56f7d29cadb96dc68f#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780) allowes to install bundle with symfony 4.

Can you make a new release with it? Thank you.

JohnnySteunwijzer commented 4 years ago

Is there any way I can use that commit in my project without a release?

andrew-demb commented 4 years ago

@JohnnySteunwijzer you can use version restriction to branch, or commit https://getcomposer.org/doc/04-schema.md#package-links

pfeiferbit commented 4 years ago

This bundle cannot be used with Symfony 4 anyway as it relies on the Assetic-Bundle which is incompatible with Symfony 4.

andrew-demb commented 4 years ago

@pfeiferbit this bundle provide a possibility to auto-configure assetic, but not requires it.

I am successfully using it (bootstrap bundle) with webpack-encore.

JohnnySteunwijzer commented 4 years ago

I'm also using it with some changes. Symfony-flex 4.4

pfeiferbit commented 4 years ago

Oh, okay, I didn't know! Sorry!