braindecode / braindecode

Deep learning software to decode EEG, ECG or MEG signals
https://braindecode.org/
BSD 3-Clause "New" or "Revised" License
782 stars 175 forks source link

changed default value of final_conv_length to 'auto' in Deep4Net #535

Closed sliwy closed 1 year ago

sliwy commented 1 year ago

After last changes, default value of final_conv_length in Deep4Net is None and code fails. Before it was mandatory to provide this paramter. I'm setting default to `"auto" -> it should not break earlier code as before it had to be specified.

codecov[bot] commented 1 year ago

Codecov Report

Merging #535 (1c4376a) into master (ae843fe) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files          63       63           
  Lines        4653     4653           
=======================================
  Hits         3931     3931           
  Misses        722      722           
robintibor commented 1 year ago

good catch! and what about shallow? should be same Problem there no?

sliwy commented 1 year ago

for shallow filter_time_length is set to 25 by default, it was the same before recent changes and it still works as before :)

bruAristimunha commented 1 year ago

Thank you @sliwy =)