Annotations are now always set in MOABB

braindecode / braindecode

Deep learning software to decode EEG, ECG or MEG signals

https://braindecode.org/

BSD 3-Clause "New" or "Revised" License

782 stars 175 forks source link

Annotations are now always set in MOABB #561

Closed dcwil closed 9 months ago

dcwil commented 10 months ago

A relatively recent update to moabb means that annotations will always be set, so for at least BNCI2014001 the cut trials come out wrong. I'm not sure what the intended approach at moabb is, and whether we will need to modify our annotating or not, but with their current workflow, this if statement will never be triggered.

https://github.com/braindecode/braindecode/blob/22da938bec9445aaa7a7a58a6abcfb14bb2d1d71/braindecode/datasets/moabb.py#L39

bruAristimunha commented 10 months ago

Nice catch! I noticed a difference in decoding results between versions, but I don't have time to go deeper now. Maybe that's the cause, do you have any proposed ideas on how to fix it @dcwil? Looks like's is only necessary to change the if.