brainelectronics / micropython-modbus

MicroPython Modbus RTU Slave/Master and TCP Server/Slave library
GNU General Public License v3.0
104 stars 45 forks source link

Update outdated documentation #55

Closed brainelectronics closed 1 year ago

brainelectronics commented 1 year ago

Added

Changed

Fixed

brainelectronics commented 1 year ago

Hey @beyonlo and @toddkarin here are the updated beautiful docs. Let me know whether this resolves #54 😃

https://micropython-modbus--55.org.readthedocs.build/en/55/

brainelectronics commented 1 year ago
beyonlo commented 1 year ago

@brainelectronics

Excellent! I liked it so much! Beautiful docs and very useful :tada:

Some possible suggestions/improvements:

  1. On the manually installation, a option is to put a example with mpremote as well, together that rshell example. As mpremote become a standard use, maybe is a good idea. mpremote cp -r umodbus/ :

  2. On the Structure, on the ISTS (INPUT STATUS) are using in some comments input registers instead input status or discrete inputs. Shouldn't use input registers to be used just for the IREGS (INPUT REGISTERS)?

A extra note: About that behaviour where the callback print always signed False, maybe a way to solve is to put on the JSON structure a option "signed" [False, True] configured by user, like as the "val" and "len". So the Slave/Client use that to know if print/use signed False or True.