search

brainfoolong / omxwebgui-v2

Web GUI for OMX Player on a Raspberry Pi
https://www.youtube.com/watch?v=4hqOzdt6KfQ
MIT License
53 stars 17 forks source link

Video player ui #16

Closed donaldsteele closed 7 years ago

donaldsteele commented 7 years ago

Hello, Added a responsive video ui for seeking and controlling the current video playback experience. Tested on android and chrome desktop running on a raspberry pi zero w.

brainfoolong commented 7 years ago

Unfortunetly this doesn't work for me. But right now i have an idea of how to use the dbus here. I will do some work when i have time for it, thank you for the pull request.

  1. There are many changed files that shouldn't have touched (glyphicons icon files)
  2. This errors appear for me 
    cat: /tmp/omxplayerdbus.root: No such file or directory
cat: /tmp/omxplayerdbus.root.pid: No such file or directory
Must have DBUS_SESSION_BUS_ADDRESS
  3. Code style don't really match the overall style of the application, make it harder to read the code.
  4. Too less generic, could be simplified to make it easier to use and better to extend.
donaldsteele commented 7 years ago

4 ) I had originally built a new view that would be a dbus json service but that was to generic based on the existing code style (you can see in revision history)

2) this could be due to a os / environment situation. The original dbus.sh i adapted (from the omxplayer main branch) used $USER in place of where root is at. However on dietpi does not set that variable so it was hard coded. If you run as a different user then root will need to be replaced with you username .

3) glyph icons were added to the project since they were not previously included .

brainfoolong commented 7 years ago

Thank you anyway, i'll check this out when i have time again. It requires some adjustments but generally i guess it's fine, altough i hadn't a chance to run it here. I guess i've mixed up 2 projects in my head while i've reviewed this pull request, therefore i false positive noticed the glyphicon thingy.