search

brainfucksec / kalitorify

Transparent proxy through Tor for Kali Linux OS
GNU General Public License v3.0
1.04k stars 225 forks source link

Extra shift call causes exit code 1 #33

Closed ViRb3 closed 4 years ago

ViRb3 commented 4 years ago

There's a shift call to get rid of the -t argument here: https://github.com/brainfucksec/kalitorify/blob/74b97362e16abc394ece7f384fbb8b3c8710ccce/kalitorify.sh#L569-L574

But also here: https://github.com/brainfucksec/kalitorify/blob/74b97362e16abc394ece7f384fbb8b3c8710ccce/kalitorify.sh#L598-L601

Since there's nothing else to remove, the command will exit with code 1, which will in turn make the script return error code 1, even though it succeeded. Maybe remove the first shift call?

brainfucksec commented 4 years ago

Hi @ViRb3, thanks for the report. You're right, that statement is totally useless. I am working on updating the program, I will commit as soon as possible

brainfucksec commented 4 years ago

@ViRb3, I've eliminated the "extra" shift command. Thank you very much for your help and for making this program better.