search

braingeneers / braingeneerspy

Python package for Braingeneers data loading, analysis, and IoT.
https://pypi.org/project/braingeneers/
MIT License
17 stars 4 forks source link

Remove SpikeData #87

Closed atspaeth closed 1 month ago

atspaeth commented 6 months ago

I'm working on refactoring out the SpikeData class and all the related analysis into a package called spikedata, then re-exporting it through braingeneers.analysis. The idea is to eventually deprecate braingeneers.analysis entirely (the new package will transparently replace it) and move the data loaders back into datasets.

So far this obviously isn't ready to merge, since the new package is only published via GitHub, not PyPI, but I wanted to make the work on this visible and have a place to discuss design stuff.

DailyDreaming commented 2 months ago

@atspaeth Is this ready for review? I haven't checked this PR in a while, and I don't want to lose your work on this.

atspaeth commented 2 months ago

@DailyDreaming Yep! Just rebased.

It's only the first step of the migration plan I had in mind, so this doesn't change the interface at all. It just gets the SpikeData object from this package now: https://github.com/braingeneers/SpikeData (and doesn't bother testing it because that package has its own tests)