brainglobe / BrainGlobe

General information, resources and dicussions for the BrainGlobe project.
https://brainglobe.info/
10 stars 1 forks source link

[BGV1] Updates to `brainreg-segment` #36

Closed willGraham01 closed 1 year ago

willGraham01 commented 1 year ago

Subtask of #33.

brainglobe/brainreg-segment

OLD TASKS (pre brainglobe-registration)

adamltyson commented 1 year ago

brainglobe/brainreg-segment

Should this be brainglobe-napari?

adamltyson commented 1 year ago

I know see that https://github.com/brainglobe/BrainGlobe/issues/37 exists, so I guess this issue is about brainreg-segment. Did we decide to merge brainreg-segment into brainreg?

willGraham01 commented 1 year ago

Yeah it's in the master issue for the new release (#33): we'll have brainreg as one package with core, segment, and napari submodules (the latter two being optionals).

The issue is more for my own sanity so I don't have to X-reference with #33 every time I tick a task off.

adamltyson commented 1 year ago

I'm leaning towards not merging brainreg-segment into brainreg, as it, or something like it should be compatible with the new brainglobe-registration plugin.

willGraham01 commented 1 year ago

I'm leaning towards not merging brainreg-segment into brainreg, as it, or something like it should be compatible with the new brainglobe-registration plugin.

Our counterargument for merging it in was that in it's current state, its only use is tied to post-processing for whatever comes out of brainreg (or similar - I can search my notes for the exact thought process / reasons).

I'd be inclined to stick to the merge plan because it reduces the number of repos we have under the brainglobe name, and (even if it is compatible with upcoming brainglobe-registration) is still going to be fundamentally tied to brainreg anyway.

brainreg-segment and brainglobe-registration are both eventually going to end up under the brainglobe-meta umbrella I presume, in which case I'd also prefer to bundle all of brainreg together. Or if this is a case of a historical naming convention, maybe we change the name so it's not so implicitly linked to brainreg?

adamltyson commented 1 year ago

The eventual new version shouldn't be tied to brainreg. I'd rather keep it unbundled and with the same name for now. Once it's compatible with brainglobe-registration it can be called brainglobe-segmentation or something.

I think when we decided to merge, we didn't have a concrete plan for the development of brainglobe-registration.

adamltyson commented 1 year ago

We could just rename it to brainglobe-segmentation now?

willGraham01 commented 1 year ago

I think when we decided to merge, we didn't have a concrete plan for the development of brainglobe-registration.

:thumbs_up: No problem (I did make the plan ~2 months ago so things are bound to have changed!).

We could just rename it to brainglobe-segmentation now?

I'll convert this issue / open a new one to do this. Renaming right now may break some things that depend on (or look for) brainreg-segment. Also I'll need to check what PyPI (hence conda) thinks about renaming.

willGraham01 commented 1 year ago

We could just rename it to brainglobe-segmentation now?

Looks like there's a standard method for renaming on PyPI, although we do have to retire the old repository. I'm guessing we don't want to retire brainreg-segment as a repository due to it's GH metrics @adamltyson ?

The (quite hacky) alternatives I can think of would be:

Slightly cleaner hack:

Slightly cleaner hack is "cleaner" because it means we won't break any of our existing dependencies on brainreg-segment as it'll continue to exist whilst we update everything else. Unless anyone objects, I'll go with this approach.

adamltyson commented 1 year ago

I think I prefer the first option, mostly because it reduces the number of repos we have and retains GH metrics etc. Also, it won't be a new tool, for now it's literally just a renaming.

adamltyson commented 1 year ago

Also, importantly it will mean that links (e.g in the paper) will redirect.

willGraham01 commented 1 year ago

Also, importantly it will mean that links (e.g in the paper) will redirect.

I wasn't aware GitHub did this :thinking: So if I rename brainglobe/brainreg-segment to brainglobe/brainglobe-segmentation, both of the following links will direct me to the same (renamed) repository?

adamltyson commented 1 year ago

I assume so, if you move a repo between orgs, it will redirect.

willGraham01 commented 1 year ago

Will pop back here and check in any case, once all the merging is done!