search

brainglobe / brainglobe-atlasapi

A lightweight python module to interact with atlases for systems neuroscience
https://brainglobe.info/documentation/brainglobe-atlasapi/index.html
BSD 3-Clause "New" or "Revised" License
125 stars 33 forks source link

Atlas name could be improved for anistropic atlases #246

Open adamltyson opened 3 years ago

adamltyson commented 3 years ago

At this line, the atlas name uses the first resolution value: https://github.com/brainglobe/bg-atlasgen/blob/f944baaf69004aca270c29dee50592369969db72/bg_atlasgen/wrapup.py#L111

This isn't particularly useful for non-isotropic atlases, but I'm not sure what would be better.

vigji commented 3 years ago

Yeah, the main reason for having the resolution in the name is mostly for atlases that come with different resolutions - eg, pretty useless for the zebrafish one. I guess that for a non-isotropic atlas that come in only one resolution it would not be very meaningful in general, as one atlas at multiple resolutions in my head make sense only if resampling is involved, at which point the atlas probably would not be anisotropic anymore

adamltyson commented 3 years ago

Makes sense to me. The resolution could be optional, thus only enforcing additional, resampled atlases to be isotropic? If we needed an additional, resampled anisotropic atlas, that could just have a different name.

vigji commented 3 years ago

yes, that would make sense for me!

On Mon, 9 Aug 2021 at 11:49, Adam Tyson @.***> wrote:

Makes sense to me. The resolution could be optional, thus only enforcing additional, resampled atlases to be isotropic? If we needed an additional, resampled anisotropic atlas, that could just have a different name.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brainglobe/brainglobe-atlasapi/issues/246, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPLDVHQZOY7GGVNGWX4U6TT36QDJANCNFSM5BWACSQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .