brainglobe / brainglobe-heatmap

Rendering anatomical heatmaps with brainrender and matplotlib
https://brainglobe.info
MIT License
34 stars 10 forks source link

Rename package to `brainglobe-heatmap(s)` #10

Closed LeonardoLupori closed 11 months ago

LeonardoLupori commented 2 years ago

Hey, thanks for the software, it's awesome!

I just wanted to let you know that on my side, after pip install bgheatmap and a successful installation, I still could not import the package, getting the error:

ModuleNotFoundError: No module named 'bgheatmap'

looking in the site-packages folder of the conda env that I'm using I noticed that the package there is actually named bgheatmaps with the final s. In fact, import bgheatmaps as bgh works great.

Maybe I'm missing something absolutely trivial, but I found it to be a bit misleading


FedeClaudi commented 2 years ago

Hey thanks for highlighting this, likely a typo during package creation. I don't think it's worth creating a new release, hopefully it won't be too confusing. I'll leave this issue up so that people can see it if they also get confused

vigji commented 2 years ago

I think maybe it is worth, it sounds like it's likely to create some headaches!

adamltyson commented 1 year ago

We agreed in the last dev meeting to move to brainglobe-xyz as a standard, so I think this package should eventually be renamed brainglobe-heatmap(s). I've changed the title to track better.