brainglobe / brainglobe-heatmap

Rendering anatomical heatmaps with brainrender and matplotlib
https://brainglobe.info
MIT License
34 stars 10 forks source link

add 'hemisphere' option to heatmap() #27

Closed carlocastoldi closed 10 months ago

carlocastoldi commented 10 months ago

Description

This small PR adds the hemisphere option in order to plot only the right, left or both hemispheres. This can be useful when comparing two different but symmetrical data.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f9e7f90) 0.00% compared to head (d0ce373) 0.00%.

Files Patch % Lines
brainglobe_heatmap/heatmaps.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 5 5 Lines 285 285 ===================================== Misses 285 285 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 10 months ago

@carlocastoldi does this work for you? Trying it out locally I get AttributeError: 'Mesh' object has no attribute 'cutWithPlane' with every example, unless hemisphere="false".

alessandrofelder commented 10 months ago

I get the same as Adam 🤔

carlocastoldi commented 10 months ago

yes, this PR depends on https://github.com/brainglobe/brainrender/pull/304