Update tools provided - Githubissues

brainglobe / brainglobe-meta

(Meta-)package repository for BrainGlobe's Python tools for computational neuroanatomy.

BSD 3-Clause "New" or "Revised" License

10 stars 0 forks source link

Description

Waiting on:

[ ] https://github.com/brainglobe/cellfinder-core/pull/187,
[ ] A new PyPI release of cellfinder_core,
[ ] Step 2 of https://github.com/brainglobe/BrainGlobe/issues/27,

What is this PR

[ ] Bug fix
[x] Addition of a new feature
[ ] Other

Why is this PR needed? Allows the command

pip install brainglobe

to install all currently-available BrainGlobe tools, and makes the tools exposed to users compatible with a conda install.

Also enables step 3 of https://github.com/brainglobe/BrainGlobe/issues/27.

What does this PR do?

References

Resolves the brainglobe-meta task in https://github.com/brainglobe/BrainGlobe/issues/27.

How has this PR been tested?

Local testing of new import guards via pip installation.

Is this a breaking change?

No.

It also means there's no longer any need for the optional morphapi and cellfinder dependencies to be specified.

Does this PR require an update to the documentation?

Install instructions have been updated to reflect the pip install manifest and the (to be completed) conda-forge recipe.

Checklist:

[ ] The code has been tested locally
[ ] Tests have been added to cover all new functionality (unit & integration)
[ ] The documentation has been updated to reflect any changes
[ ] The code has been formatted with pre-commit

Codecov Report

Patch coverage: 66.66% and project coverage change: -20.77 :warning:

Comparison is base (b2ad646) 90.00% compared to head (ea3a5ce) 69.23%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #15 +/- ## =========================================== - Coverage 90.00% 69.23% -20.77% =========================================== Files 1 2 +1 Lines 20 26 +6 =========================================== Hits 18 18 - Misses 2 8 +6 ``` | [Impacted Files](https://app.codecov.io/gh/brainglobe/brainglobe-meta/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [brainglobe/\_tensorflow\_handle.py](https://app.codecov.io/gh/brainglobe/brainglobe-meta/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5nbG9iZS9fdGVuc29yZmxvd19oYW5kbGUucHk=) | `62.50% <62.50%> (ø)` | | | [brainglobe/\_\_init\_\_.py](https://app.codecov.io/gh/brainglobe/brainglobe-meta/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5nbG9iZS9fX2luaXRfXy5weQ==) | `72.22% <75.00%> (-17.78%)` | :arrow_down: |