brainglobe / brainglobe-meta

(Meta-)package repository for BrainGlobe's Python tools for computational neuroanatomy.
BSD 3-Clause "New" or "Revised" License
10 stars 0 forks source link

`cellfinder` guard updates #24

Closed willGraham01 closed 1 year ago

willGraham01 commented 1 year ago

Description

What is this PR

Why is this PR needed?

Delegates the cellfinder-core tensorflow guards to the corresponding package.

If cellfinder-core is installed in an unusable state, it will not be exposed to the user and a warning will be thrown when trying to import the brainglobe package.

What does this PR do?

Modifies __init__.py to prevent cellfinder-core's exposure if it has been installed in an unusable state (IE, no tensorflow).

Updates the dependency tree for cellfinder in accordance with cellfinder/245.

How has this PR been tested?

Local install testing.

Is this a breaking change?

Does this PR require an update to the documentation?

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 62.50% and project coverage change: +2.19% :tada:

Comparison is base (65875e2) 69.23% compared to head (56a70f5) 71.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== + Coverage 69.23% 71.42% +2.19% ========================================== Files 2 2 Lines 26 28 +2 ========================================== + Hits 18 20 +2 Misses 8 8 ``` | [Files Changed](https://app.codecov.io/gh/brainglobe/brainglobe-meta/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [brainglobe/\_conda\_handles.py](https://app.codecov.io/gh/brainglobe/brainglobe-meta/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5nbG9iZS9fY29uZGFfaGFuZGxlcy5weQ==) | `57.14% <57.14%> (ø)` | | | [brainglobe/\_\_init\_\_.py](https://app.codecov.io/gh/brainglobe/brainglobe-meta/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5nbG9iZS9fX2luaXRfXy5weQ==) | `85.71% <100.00%> (+13.49%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.