napari.typing > napari.types

brainglobe / brainglobe-napari-io

Read and write files from the BrainGlobe neuroanatomy suite

BSD 3-Clause "New" or "Revised" License

13 stars 3 forks source link

napari.typing > napari.types #46

Closed alessandrofelder closed 1 year ago

alessandrofelder commented 1 year ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed? Seems to have caused CI failure elsewhere?

What does this PR do? Fixes an import statement that tries to import something that doesn't exist.

References

n/a

How has this PR been tested?

n/a

Is this a breaking change?

Does this PR require an update to the documentation?

Checklist:

[n/a] The code has been tested locally
[n/a] Tests have been added to cover all new functionality (unit & integration)
[n/a] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/brainglobe/brainglobe-napari-io/46 Created: 2023-08-22T13:38:15.078754

willGraham01 commented 1 year ago

Something to flag here - I would have thought we'd catch something like this in our test suite on this repository... but it looks like we only have 3 test files and one of them is a placeholder:

The culprit: https://github.com/brainglobe/brainglobe-napari-io/blob/main/brainglobe_napari_io/tests/test_brainglobe_napari_io.py

Probably should introduce some more tests so that we don't catch CI-breaks on other repos?

adamltyson commented 1 year ago

Something to flag here - I would have thought we'd catch something like this in our test suite on this repository... but it looks like we only have 3 test files and one of them is a placeholder:
* The culprit: https://github.com/brainglobe/brainglobe-napari-io/blob/main/brainglobe_napari_io/tests/test_brainglobe_napari_io.py
Probably should introduce some more tests so that we don't catch CI-breaks on other repos?

There's an open issue, it's just been open for a while. This repo should be fairly easy to test though.