Closed saarah815 closed 2 months ago
Attention: Patch coverage is 88.88889%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 82.98%. Comparing base (
538cdd2
) to head (62b095a
). Report is 1 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
brainglobe_registration/utils/utils.py | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I just noticed that we have the display_info
convenience function in brainglobe-utils.qtpy.dialog
that takes care of the Qt internals. This can simplify the code even further, you can import it and just call display_info
with the corresponding title and message if no atlases are installed!
Last set of changes I promise! I'll mark it as approved, you can make the final changes and then I'll merge it in!
Perfect, thank you!
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
If user has no atlases installed, this widget informs user that they need to install atlas(es) before they are able to use BrainGlobe Registration plugin.
What does this PR do?
If no atlases installed:
References
Please reference any existing issues/PRs that relate to this PR.
Issue #15
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
N/A
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
N/A
Checklist: