brainglobe / brainglobe-registration

Registration to BrainGlobe atlases in napari using Elastix
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Fix sample data loading to be independent of current working directory #47

Closed IgorTatarnikov closed 2 months ago

IgorTatarnikov commented 2 months ago

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

Why is this PR needed? Currently, the sample data could only be loaded if napari was started in the package directory. Otherwise, you'd get a file not found error.

What does this PR do? Allows the sample data to be opened regardless of the working directory.

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Tested locally by visual inspection.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (9531886) to head (5b1eb88). Report is 1 commits behind head on main.

Files Patch % Lines
brainglobe_registration/sample_data.py 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ========================================== - Coverage 81.15% 79.69% -1.47% ========================================== Files 8 9 +1 Lines 382 389 +7 ========================================== Hits 310 310 - Misses 72 79 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.