brainglobe / brainglobe-stitch

A napari plugin for stitching large tiled 3D imaging datasets
BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

Extract and replace data in overlapping regions between tiles #20

Open IgorTatarnikov opened 1 week ago

IgorTatarnikov commented 1 week ago

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

Why is this PR needed? In order to correct for brightness differences, and interpolate over the stitches in the final fused images it's important to keep track of which tiles overlap and the coordinates of the overlap in both local (relative to the tile itself) and global (relative to the final fused image) coordinates.

What does this PR do?

How has this PR been tested?

Tests added to cover the new functionality.

NOTE: To test the functionality locally you must install Fiji and also add BigStitcher to the update sites. This can be done using the GUI see here or via the command line after installing Fiji.

./ImageJ-linux64 --update add-update-sites "BigStitcherUpdate" "https://sites.imagej.net/BigStitcher/" ./ImageJ-linux64 --update update

Replace ImageJ-linux64 with the path to the local ImageJ executable.

Three different datasets are available for testing:

Is this a breaking change?

No

Does this PR require an update to the documentation?

Yes, will come in subsequent PR.

Checklist:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.54%. Comparing base (ffa996a) to head (6a2a380). Report is 25 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ========================================== + Coverage 95.20% 95.54% +0.33% ========================================== Files 6 6 Lines 626 673 +47 ========================================== + Hits 596 643 +47 Misses 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.