Closed IgorTatarnikov closed 3 months ago
Attention: Patch coverage is 93.47826%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 96.89%. Comparing base (
68f0d78
) to head (8302bac
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
brainglobe_stitch/file_utils.py | 87.50% | 5 Missing :warning: |
brainglobe_stitch/image_mosaic.py | 92.59% | 2 Missing :warning: |
brainglobe_stitch/stitching_widget.py | 96.61% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
brainglobe-stitch
will use BigStitcher to calculate the precise alignments for the tiles. We need a way to call BigStitcher from withinbrainglobe-stitch
and then read in and utilise the results.What does this PR do? This PR does three things:
Adds a new function
run_big_stitcher
this calls BigStitcher using the command line to runbigstitcher_macro.ijm
.bigstitcher_macro.ijm
will call import the rough alignment from a file automatically generated when data is added toImageMosaic
and then refine the alignment. The final result is saved in the.xml
file that's present in the mesoSPIM directory.Added a
stitch
function toImageMosaic
that calls therun_big_stitcher
function from above and aread_big_stitcher_transforms
function to read the results of running BigStitcher and update the positions of the tiles.Added a way to call the stitching functions from within the napari widget. The user must provide a path to a Fiji installation that already has BigStitcher installed.
NOTE: To run local tests you must install Fiji and also add BigStitcher to the update sites. This can be done using the GUI see here or via the command line after installing Fiji.
Replace
ImageJ-linux64
with the path to the local ImageJ executable.How has this PR been tested?
This PR has been tested locally and new tests have been added that cover the features.
Three different datasets are available for testing:
Is this a breaking change?
No.
Does this PR require an update to the documentation?
Yes, but not in this PR.
Checklist: