brainglobe / brainglobe-utils

Shared general purpose tools for the BrainGlobe project
MIT License
11 stars 1 forks source link

Qt based utilities for BrainGlobe #13

Closed IgorTatarnikov closed 11 months ago

IgorTatarnikov commented 11 months ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

Why is this PR needed? Code relating to setup of basic widgets was being duplicated across multiple BrainGlobe repositories.

What does this PR do? This PR introduces a function to create a logo widget and a set of classes to represent collapsible widgets and a parent container that syncs their states.

References

Closes #4, closes #9

How has this PR been tested?

All new code has tests written for it.

Is this a breaking change?

No

Does this PR require an update to the documentation?

Yes, docstrings provided for all public facing functions.

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a20037e) 61.62% compared to head (e3f8650) 64.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13 +/- ## ========================================== + Coverage 61.62% 64.04% +2.42% ========================================== Files 31 33 +2 Lines 787 840 +53 ========================================== + Hits 485 538 +53 Misses 302 302 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alessandrofelder commented 11 months ago

Reasonably confident this is fine now - and there's some temporary GH actions glitches that cause timeouts. I'll therefore merge and check that the CI passes on the merge.

alessandrofelder commented 11 months ago

Confirming tests pass on merge so all good ✅