Closed K-Meech closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.07%. Comparing base (
87ca009
) to head (830c1d2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok - all fixed now! Data has been moved to the data
folder, + some fixtures changed to parametrize
, + I noticed I'd missed the test_pandas/test_pandas_misc
file so I updated that to match the rest. @willGraham01 - could you maybe take a quick look, then merge if you're happy with it? Thanks!
Description
What is this PR
Why is this PR needed? Currently tests don't access the test data directory in a consistent way. For example, many use
os.path.join("tests", "data")
which meanspytest
fails when run from any location apart from the top directory.Also, fixtures aren't consistently used for data generated inside of test modules.
What does this PR do?
This PR creates a
data_path
fixture inside oftests/tests/conftest.py
that can be re-used by all tests. This ensurespytest
can be run from any location successfully.The PR also makes sure that any data generated inside of tests is wrapped into a fixture.
References
None
How has this PR been tested?
All tests pass locally.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: