brainglobe / brainglobe-utils

Shared general purpose tools for the BrainGlobe project
MIT License
11 stars 1 forks source link

Be permissive about tiff axis metadata #75

Closed alessandrofelder closed 4 months ago

alessandrofelder commented 4 months ago

Description

What is this PR

Why is this PR needed?

Current code loading tiff z stacks into memory throws an error, but...

What does this PR do?

Follow-up to https://github.com/brainglobe/brainglobe-utils/pull/73 Modifies read_z_stack to write debug logs instead of throwing an error, if a tiff stack with no axis metadata is read. Adds tests that check that debug log is called in these cases.

References

PR discussion linked above

How has this PR been tested?

New tests added.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.53%. Comparing base (a1a53b5) to head (fcf878b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 89.76% 90.53% +0.77% ========================================== Files 35 35 Lines 1427 1427 ========================================== + Hits 1281 1292 +11 + Misses 146 135 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.