codecov[bot]
commented
4 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.43%. Comparing base (
6185777) to head (38c21ac).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================== - Coverage 90.53% 90.43% -0.11% ========================================== Files 35 35 Lines 1427 1411 -16 ========================================== - Hits 1292 1276 -16 Misses 135 135 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
What is this PR
Why is this PR needed?
pynrrdseems to be causing a few issues with newer versions of Python (t doesn't seem to have been updated for 2 years). Mostly because it uses nptyping, which itself needs updating.However, I don't think we need nrrd IO functionality in brainglobe, because we only deal with tiffs and nii. We may use this functionality in the atlas generation code, but I think if we do, it should be a specific requirement for that script (and not for the whole of brainglobe as it is at the moment).
Keen to know if this is going to break anything, but I don't think it should.
What does this PR do? Removes all nrrd IO code. It also removes (what I think is) some outdated error/warning handling.
References
N/A
How has this PR been tested?
Removed nrrd tests, and ran other tests as normal.
Is this a breaking change?
I don't think so.
Does this PR require an update to the documentation?
Yes, the reference to nrrd IO needs to be removed from the website docs.
Checklist: