Closed niksirbi closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.59%. Comparing base (
a64cd9a
) to head (52a8fdc
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
What is this PR
Why is this PR needed? We were providing optional dependencies via
brainglobe-utils[napari]
. These includedqtpy
,superqt
, andnapari
itself. I realised that the actual code for the collapsible widgets (located in theqtpy
folder), doesn't actually make use ofnapari
, so that dependency was unnecessary.What does this PR do? We instead provide
brainglobe-utils[qt]
, which includeqtpy
,superqt
as before, but NOTnapari
. This should also simplify dependency management in packages that rely on the collapsible widgets.References
I realised this while working on a napari widget for movement
How has this PR been tested?
Existing tests still pass (because napari was actually never even installed in the
dev
environment).Is this a breaking change?
In a way, packages that depended on collapsible widgets (
brainglobe-stitch
andbrainglobe-registration
?) need to update their dependencies tobrainglobe-utils[qt]
, and make sure to have a separatenapari
dependency. That's why I'm tagging @IgorTatarnikov as reviewer.Does this PR require an update to the documentation?
The README has been updated accordingly.
Checklist: