brainglobe / brainglobe-utils

Shared general purpose tools for the BrainGlobe project
MIT License
11 stars 1 forks source link

Add transform widget #88

Closed adamltyson closed 1 month ago

adamltyson commented 1 month ago

Closes https://github.com/brainglobe/brainglobe-utils/issues/26. I decided to "brand" this widget as brainmapper as it essentially adds the missing functionality of brainmapper to napari.

This also effectively reverses https://github.com/brainglobe/brainglobe-utils/pull/84, as we now need napari.

I'm struggling to get the tests cache to work, so they're taking much longer than they should.

Docs and a tutorial need to be added, but I'm holding off doing this until this PR is merged, as the docs will depend on the final UI. Basic instructions are:

Once this is merged we should:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 99.18367% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (78533f8) to head (52aab75).

Files Patch % Lines
brainglobe_utils/brainmapper/transform_widget.py 99.01% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #88 +/- ## ========================================== + Coverage 91.59% 92.68% +1.08% ========================================== Files 35 37 +2 Lines 1607 1845 +238 ========================================== + Hits 1472 1710 +238 Misses 135 135 ``` | [Flag](https://app.codecov.io/gh/brainglobe/brainglobe-utils/pull/88/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [numba](https://app.codecov.io/gh/brainglobe/brainglobe-utils/pull/88/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | `92.62% <99.18%> (+1.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.