Closed alessandrofelder closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.73%. Comparing base (
0d463f6
) to head (f2a5f21
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
What is this PR
Why is this PR needed?
read_with_dask
, when the metadata for all tiffs is specified in a single tiff's metadata.read_with_dask
lack return value and parameters in docsread_with_dask
ignores.tiff
files (only finds.tif
files).What does this PR do?
Ignores the OME metadata, so we can correctly read OME tiff files with dask. Also improvements to docs and ability to read
.tiff
files lazily, and better error handling.References
Closes #79
How has this PR been tested?
Locally by @niksirbi and me
Is this a breaking change?
I don't think so.
Does this PR require an update to the documentation?
Docstrings updated.
Checklist:
we would need to make, or download, suitable data to test this on. I tried but only got so far, this will be addressed separately later (
ignore-ome-test
branch in #99 )- so we can useread_with_dask
for more urgent work. I did add a negative test for a new error that is now being raised.