brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Cache for cellfinder workflow tests #102

Closed sfmig closed 2 months ago

sfmig commented 2 months ago

Description

What is this PR

Why is this PR needed? We are trying to speed up tests in CI. This PR adds a cache for the cellfinder workflow tests that run in CI.

What does this PR do? Adds a cache step to the test job that runs in CI.

References

65

How has this PR been tested?

Checks for this PR should pass.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.45%. Comparing base (b5f62ef) to head (2a7873c). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ========================================== + Coverage 79.38% 84.45% +5.06% ========================================== Files 18 17 -1 Lines 917 862 -55 ========================================== Hits 728 728 + Misses 189 134 -55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 2 months ago

@sfmig, naively, shouldn't this speed up the tests?

sfmig commented 2 months ago

@adamltyson yeah I was expecting at least a few minutes of improvement, but it seems I didn't implement it correctly. Will revert to draft.