brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

pin to pytorch-version of cellfinder #118

Closed alessandrofelder closed 3 months ago

alessandrofelder commented 3 months ago

Description

What is this PR

Why is this PR needed?

Latest release of brainglobe-workflows is incompatible with latest cellfinder, because it tries to import tensorflow-related functionality. This is fixed in the development code by https://github.com/brainglobe/brainglobe-workflows/pull/112 but not released yet.

What does this PR do? Makes sure the next release pins to a cellfinder version >= 1.3.0, so the API between the two packages in in-sync and up-to-date.

References

\

How has this PR been tested?

Not sure how to test this 😬 I have convinced myself I have thought this through.

Is this a breaking change?

No. It's an adaptation to the latest cellfinder release.

Does this PR require an update to the documentation?

No

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.83%. Comparing base (fdfbcea) to head (1434def).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ======================================= Coverage 85.83% 85.83% ======================================= Files 17 17 Lines 847 847 ======================================= Hits 727 727 Misses 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.