brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Add brainglobe-atlasapi to `latest-github-requirements` #120

Closed sfmig closed 1 week ago

sfmig commented 2 weeks ago

Description

What is this PR

Why is this PR needed? The current latest-github-requirements.txt list includes all the dependencies of the brainglobe-meta package, except for brainglobe-atlasapi. I am not sure why we didn't include that one, but I noticed brainrender depends on it.

So as it is now, brainrender will be installed using the latest-github version, but brainglobe-atlasapi will remain in the pip version.

We can verify this by checking the logs of this run which used latest-github dependencies. Al brainglobe dependencies are indeed from github except for brainglobe-atlasapi.

What does this PR do? It adds brainglobe-atlasapi to the latest-github requirements file.

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

\

Is this a breaking change?

\

Does this PR require an update to the documentation?

\

Checklist:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.83%. Comparing base (b727ce0) to head (d8bf824).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== + Coverage 85.71% 85.83% +0.11% ========================================== Files 17 17 Lines 847 847 ========================================== + Hits 726 727 +1 + Misses 121 120 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.