brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Rename incorrect instances of cellfinder to brainmapper #67

Closed adamltyson closed 8 months ago

adamltyson commented 9 months ago

Before release, this will need brainglobe-napari-io to be updated to detect the renamed brainmapper.json.

Closes #63

As it turns out the log file is named automatically, so this just changes the metadata file.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2da996a) 81.39% compared to head (17a52a1) 81.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== - Coverage 81.39% 81.33% -0.07% ========================================== Files 32 32 Lines 1586 1586 ========================================== - Hits 1291 1290 -1 - Misses 295 296 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 8 months ago

https://github.com/brainglobe/brainglobe-napari-io/issues/59 has been created to support this change. Both packages will need re-releasing, with workflows depending on the latest version of brainglobe-napari-io.

adamltyson commented 8 months ago

Following the merge of https://github.com/brainglobe/brainreg/pull/172, this package should also pin the latest version of brainreg upon release.