update to new cellfinder function names - Githubissues

brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.

BSD 3-Clause "New" or "Revised" License

9 stars 2 forks source link

update to new cellfinder function names #87

Closed alessandrofelder closed 2 months ago

alessandrofelder commented 2 months ago

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed?

We've updated some function names as part of https://github.com/brainglobe/cellfinder/pull/394

What does this PR do? Updates the function names.

When this is merged, I think we should

[x] release cellfinder 1.1.2
[ ] release brainglobe 1.0.5, which should depend on cellfinder >= 1.1.2
[ ] release brainglobe-workflows 1.1.5 depending on brainglobe >=1.0.5

References

https://github.com/brainglobe/cellfinder/pull/394 and https://github.com/brainglobe/cellfinder/issues/393

How has this PR been tested?

Locally, which current main of cellfinder installed.

Is this a breaking change?

Yes, this will now require cellfinder >=1.1.2

Does this PR require an update to the documentation?

No.

Checklist:

[x] The code has been tested locally
[n/a] Tests have been added to cover all new functionality (unit & integration)
[n/a] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

alessandrofelder commented 2 months ago

Superceded by #89