Closed matham closed 1 month ago
Thanks for this @matham. Just to let you know we should get back to you with a review next week.
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 85.69%. Comparing base (
918ac9f
) to head (ae9297d
).
Files | Patch % | Lines |
---|---|---|
brainglobe_workflows/brainmapper/main.py | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
benchmark test failure expected as we have not released cellfinder with the required new API yet. Other tests pass.
This is part of this PR: https://github.com/brainglobe/cellfinder/pull/397 and https://github.com/brainglobe/brainglobe-utils/pull/67.
I had to fix this manually for the tests to pass. But this is an issue with the repo, not these changes:
Then is succeded except of these tests, which I don't think are related to this PR