brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

[BUG] `brainmapper` update needed in light of CLI fails in `cellfinder` #90

Closed willGraham01 closed 2 months ago

willGraham01 commented 2 months ago

https://github.com/brainglobe/cellfinder/pull/394 introduced fail-safes against overwriting package files in the cellfinder package, however in the process changed the content of the source_files.py module so one of the functions that we depend on in this package is no longer available.

As such, both CLIs now fail since workflows is using a too-recent version of cellfinder, and correspondingly cellfinder is incompatible with the current version of brainmapper.

To Fix

adamltyson commented 2 months ago

Does this PR fix this? https://github.com/brainglobe/brainglobe-workflows/pull/89

willGraham01 commented 2 months ago

It looks like it should, but the CI is failing.

It looks like the either the newer function can't be used to overwrite a config file, or workflows is looking in the wrong folder to begin with.

alessandrofelder commented 2 months ago

@IgorTatarnikov and I are hopefully fixing this on the cellfinder side now (https://github.com/brainglobe/cellfinder/pull/400) which we think combined with #89 should put things in order again.

alessandrofelder commented 2 months ago

Fixed by https://github.com/brainglobe/brainglobe-workflows/releases/tag/v1.1.5