brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Remove entry point for cellfinder workflow #93

Closed sfmig closed 2 months ago

sfmig commented 2 months ago

Description

What is this PR

Why is this PR needed? We expect that the main way the workflows will be useful for users is as reference scripts that they can "copy-paste" and adapt to their workflows. Therefore for simplicity we agreed to remove the entry point for the cellfinder workflow script.

Related to #9

What does this PR do? Removes the entry point to the cellfinder workflow script

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

We had smoke tests for the entry point before but these are removed in this PR.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.38%. Comparing base (34c8404) to head (61485e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================== - Coverage 79.43% 79.38% -0.05% ========================================== Files 18 18 Lines 924 917 -7 ========================================== - Hits 734 728 -6 + Misses 190 189 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alessandrofelder commented 2 months ago

Could you update the PR description somehow (even just a short sentence linking to a larger issue, which is only partially addressed by this PR) so our future selves remember why we did this, please?

sfmig commented 2 months ago

yes sorry, I completely missed it!